fix(cdk:popper): popper shouldn't update if reference is display none #1653
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 345 345
Lines 32285 32285
Branches 3685 3684 -1
=======================================
Hits 29895 29895
Misses 2390 2390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior
当 reference 为dispaly:none 隐藏时，虽然位置不会更新，但箭头位置和placement还是会更新，导致隐藏场景下显示不正常
What is the new behavior?
在reference 为 display:none时，不再更新Placement以及arrow位置
Other information
隐藏时不更新是为了解决例如reference是hover才显示的场景